jiridanek commented on a change in pull request #1048: URL: https://github.com/apache/qpid-dispatch/pull/1048#discussion_r581731556
########## File path: tests/lsan.supp ########## @@ -23,15 +44,56 @@ leak:_ctypes_alloc_format_string leak:__strdup #### -#### Miscellaneous 3rd party libraries, test code, etc: +#### Miscellaneous 3rd party libraries: #### -leak:*libpython* -leak:*libwebsockets* -leak:*python2* +### Python -# We should be able to uncomment these once all known dispatch leaks have been fixed -leak:*libqpid-proton* +# these Python leaks happen even after simple Py_Initialize(); Py_Finalize(); +# https://bugs.python.org/issue1635741 +leak:^_PyObject_Realloc +leak:^PyObject_Malloc$ +leak:^PyThread_allocate_lock$ -# Ignore test code -leak:run_unit_tests.c +# the PyMalloc mechanism is incompatible with Valgrind, it must be disabled or reported "leaks" must be suppressed Review comment: It isn't really overridden. The two .so suppressions simply cover all the Python suppressions that went before. I am thinking I could remove the conditional CMake logic and put the .so suppressions for python there always. The only leak I flushed out by doing this in the more complicated way is th `IoAdapter` one, and that is fairly insignificant. There is about 4 or 5 instances of the class, only. In the whole qdr run. So that leak is hardly the most significant one. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
