mklaca commented on a change in pull request #76:
URL: https://github.com/apache/qpid-broker-j/pull/76#discussion_r595069771
##########
File path:
broker-plugins/user-connection-limits/src/main/java/org/apache/qpid/server/user/connection/limits/config/BlockingRule.java
##########
@@ -16,29 +16,43 @@
* specific language governing permissions and limitations
* under the License.
*/
+package org.apache.qpid.server.user.connection.limits.config;
-package org.apache.qpid.server.security.access.config.connection;
+import org.apache.qpid.server.user.connection.limits.plugins.UclRule;
-import org.apache.qpid.server.security.access.config.ObjectProperties;
-import org.apache.qpid.server.transport.AMQPConnection;
-
-public class ConnectionPrincipalLimitRule extends
ConnectionPrincipalStatisticsRule
+final class BlockingRule extends AbstractRule
Review comment:
Blocked user has special treatment and using the magic constant 0 is
confusing because 0 means "no limit" in many another situation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
