mklaca commented on a change in pull request #76:
URL: https://github.com/apache/qpid-broker-j/pull/76#discussion_r595083040



##########
File path: 
broker-core/src/main/java/org/apache/qpid/server/virtualhost/UserConnectionLimitChangeListener.java
##########
@@ -0,0 +1,78 @@
+package org.apache.qpid.server.virtualhost;
+
+import org.apache.qpid.server.model.AbstractConfigurationChangeListener;
+import org.apache.qpid.server.model.ConfiguredObject;
+import org.apache.qpid.server.model.VirtualHost;
+import org.apache.qpid.server.model.VirtualHostUserConnectionLimitProvider;
+
+import java.util.HashSet;
+import java.util.Objects;
+import java.util.Set;
+
+final class UserConnectionLimitChangeListener extends 
AbstractConfigurationChangeListener

Review comment:
       In case of multiple connection limiters every virtual host needs a 
master coordinator that keeps the consistency of the counters inside the 
connection limiters. Hence, the functionality can not be moved. The master 
coordinator has to be notified about the change.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Reply via email to