mklaca commented on a change in pull request #76:
URL: https://github.com/apache/qpid-broker-j/pull/76#discussion_r595113827
##########
File path:
broker-core/src/main/java/org/apache/qpid/server/virtualhost/AbstractVirtualHost.java
##########
@@ -320,6 +323,8 @@ public AbstractVirtualHost(final Map<String, Object>
attributes, VirtualHostNode
_fileSystemSpaceCheckerJobContext =
getSystemTaskControllerContext("FileSystemSpaceChecker["+getName()+"]",
_principal);
_fileSystemSpaceChecker = new FileSystemSpaceChecker();
+ _userConnectionLimiter = UserConnectionLimiter.noLimits();
+ _userConnectionLimitChangeListener = new
UserConnectionLimitChangeListener(this);
Review comment:
The "this" pointer should not be used before finished construction. But
this technique is already used multiple times in VirtualHost class and the fix
requires significant refactoring. If you wish to fix it raise a separate bug
fix please.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
