Github user hbdeshmukh commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/217#discussion_r107947575
--- Diff: catalog/PartitionSchemeHeader.hpp ---
@@ -48,6 +50,13 @@ class Type;
**/
class PartitionSchemeHeader {
public:
+ // A vector for partitioning catalog attribute .
+ typedef std::vector<attribute_id> PartitionAttributeIds;
+
+ // A boundary for multi-attribute partitions.
+ // PartitionValues.size() should be equal to
PartitionAttributeIds.size().
+ typedef std::vector<TypedValue> PartitionValues;
--- End diff --
A clearer and more informative name should be ``PartitionBoundaryValues``.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
