Github user zuyu commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/217#discussion_r107969229
  
    --- Diff: catalog/PartitionSchemeHeader.hpp ---
    @@ -48,6 +50,13 @@ class Type;
      **/
     class PartitionSchemeHeader {
      public:
    +  // A vector for partitioning catalog attribute .
    +  typedef std::vector<attribute_id> PartitionAttributeIds;
    +
    +  // A boundary for multi-attribute partitions.
    +  // PartitionValues.size() should be equal to 
PartitionAttributeIds.size().
    +  typedef std::vector<TypedValue> PartitionValues;
    --- End diff --
    
    Sorry, the comment is not that clear. This represents the corresponding 
values for `PartitionAttributeIds`, and is also used to store the partition 
range boundaries for a range-based partition.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to