Github user hbdeshmukh commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/217#discussion_r107948593
--- Diff: catalog/PartitionSchemeHeader.hpp ---
@@ -180,16 +190,17 @@ class HashPartitionSchemeHeader : public
PartitionSchemeHeader {
* @brief Calulate the partition id into which the attribute value
* should be inserted.
*
- * @param value_of_attribute The attribute value for which the
- * partition id is to be determined.
+ * @param value_of_attributes The attribute value for which the
+ * partition id is to be determined.
* @return The partition id of the partition for the attribute value.
**/
partition_id getPartitionId(
- const TypedValue &value_of_attribute) const override {
+ const PartitionValues &value_of_attributes) const override {
--- End diff --
In the type definition of ``PartitionValues``, you said it is for
representing the boundary for partition values. That doesn't seem true here.
Why not just use the vector of ``TypedValue`` instead?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
