> On May 10, 2017, 8:55 a.m., Colm O hEigeartaigh wrote:
> > Why not use try with resources here? e.g:
> >
> > try (FileInputStream in = new FileInputStream(propFile)) {
> > installProperties.load(in);
> > } catch (IOException ex) {
> > ..
> > }
Ok. You are right. This segment code should be refactored. I had rebuilt and
updated the patch. Thanks.
- Qiang
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58732/#review174432
-----------------------------------------------------------
On May 10, 2017, 1:22 p.m., Qiang Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58732/
> -----------------------------------------------------------
>
> (Updated May 10, 2017, 1:22 p.m.)
>
>
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O
> hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan
> Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1547
> https://issues.apache.org/jira/browse/RANGER-1547
>
>
> Repository: ranger
>
>
> Description
> -------
>
> The XmlConfigChanger does not have any error messages when some exceptions
> occur.
>
>
> Diffs
> -----
>
>
> agents-installer/src/main/java/org/apache/ranger/utils/install/XmlConfigChanger.java
> ba949bd
>
>
> Diff: https://reviews.apache.org/r/58732/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qiang Zhang
>
>
