> On May 10, 2017, 1:57 p.m., Colm O hEigeartaigh wrote:
> > Is there any reason we can't make "installProperties" private? I think the
> > change could be simplified to:
> >
> > try (FileInputStream in = new FileInputStream(propFile)) {
> > installProperties.load(in);
> > } catch (...)
> >
> > in.close() will be called automatically.
Is there any reason we can't make "installProperties" private?
>From whole perspective, this class have some faults in variables and methods.
>In order not to introduce new issues, I did not carry out in-depth
>refactoring. So the property of the method remains unchanged.
For the in.close(), you are right. I had modified it and updated the patch.
- Qiang
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58732/#review174473
-----------------------------------------------------------
On May 10, 2017, 1:22 p.m., Qiang Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58732/
> -----------------------------------------------------------
>
> (Updated May 10, 2017, 1:22 p.m.)
>
>
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O
> hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan
> Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1547
> https://issues.apache.org/jira/browse/RANGER-1547
>
>
> Repository: ranger
>
>
> Description
> -------
>
> The XmlConfigChanger does not have any error messages when some exceptions
> occur.
>
>
> Diffs
> -----
>
>
> agents-installer/src/main/java/org/apache/ranger/utils/install/XmlConfigChanger.java
> ba949bd
>
>
> Diff: https://reviews.apache.org/r/58732/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qiang Zhang
>
>
