> On May 11, 2017, 8:30 a.m., Colm O hEigeartaigh wrote: > > Hi, > > > > You need to put the FileInputStream declaration inside the rounded brackets > > like I mentioned in my last comment, e.g.: > > > > try (FileInputStream ...)
Ok, I fixed it according to your opinion. Thanks. - Qiang ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58732/#review174612 ----------------------------------------------------------- On May 11, 2017, 9:03 a.m., Qiang Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58732/ > ----------------------------------------------------------- > > (Updated May 11, 2017, 9:03 a.m.) > > > Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O > hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan > Neethiraj, and Velmurugan Periasamy. > > > Bugs: RANGER-1547 > https://issues.apache.org/jira/browse/RANGER-1547 > > > Repository: ranger > > > Description > ------- > > The XmlConfigChanger does not have any error messages when some exceptions > occur. > > > Diffs > ----- > > > agents-installer/src/main/java/org/apache/ranger/utils/install/XmlConfigChanger.java > ba949bd > > > Diff: https://reviews.apache.org/r/58732/diff/4/ > > > Testing > ------- > > > Thanks, > > Qiang Zhang > >
