> On June 15, 2017, 11:42 p.m., Madhan Neethiraj wrote: > > agents-common/src/main/resources/service-defs/ranger-servicedef-tag.json > > Lines 75 (patched) > > <https://reviews.apache.org/r/60140/diff/1/?file=1752156#file1752156line75> > > > > Consider using a shorter name, like 'expression' - as this will be used > > in policy UI.
Madhan, In the UI it is showing the "label" field (Script in this case) as the Policy condition. Should I change this to "Expression" instead? - Sailaja ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60140/#review178066 ----------------------------------------------------------- On June 15, 2017, 11:21 p.m., Sailaja Polavarapu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60140/ > ----------------------------------------------------------- > > (Updated June 15, 2017, 11:21 p.m.) > > > Review request for ranger, Abhay Kulkarni, Madhan Neethiraj, and Velmurugan > Periasamy. > > > Bugs: RANGER-1647 > https://issues.apache.org/jira/browse/RANGER-1647 > > > Repository: ranger > > > Description > ------- > > Updated tag service def with new policy condition and also updated the unit > tests to use tag attributes for policy condition. > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerScriptConditionEvaluator.java > 48ffc38 > > agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerScriptExecutionContext.java > b0bba80 > agents-common/src/main/resources/service-defs/ranger-servicedef-tag.json > 3bad222 > agents-common/src/test/resources/policyengine/resourceTags.json 9523ca0 > > agents-common/src/test/resources/policyengine/test_policyengine_tag_hive_filebased.json > c2cb0b3 > > > Diff: https://reviews.apache.org/r/60140/diff/1/ > > > Testing > ------- > > 1. Modified unit tests based on the new policy condition. > 2. Patched an existing cluster with the new service def changes and validated > that the new policy condition is shown for tag based policies. > > > Thanks, > > Sailaja Polavarapu > >
