----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60140/#review178727 -----------------------------------------------------------
Ship it! Ship It! - Madhan Neethiraj On June 22, 2017, 6:02 p.m., Sailaja Polavarapu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60140/ > ----------------------------------------------------------- > > (Updated June 22, 2017, 6:02 p.m.) > > > Review request for ranger, Abhay Kulkarni, Madhan Neethiraj, and Velmurugan > Periasamy. > > > Bugs: RANGER-1647 > https://issues.apache.org/jira/browse/RANGER-1647 > > > Repository: ranger > > > Description > ------- > > Updated tag service def with new policy condition and also updated the unit > tests to use tag attributes for policy condition. > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerScriptConditionEvaluator.java > 48ffc38 > > agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerScriptExecutionContext.java > b0bba80 > agents-common/src/main/resources/service-defs/ranger-servicedef-tag.json > 3bad222 > agents-common/src/test/resources/policyengine/resourceTags.json 9523ca0 > agents-common/src/test/resources/policyengine/test_policyengine_owner.json > 82a6632 > > agents-common/src/test/resources/policyengine/test_policyengine_tag_hive.json > 04b9afe > > agents-common/src/test/resources/policyengine/test_policyengine_tag_hive_filebased.json > c2cb0b3 > > security-admin/src/main/java/org/apache/ranger/patch/PatchForTagServiceDefUpdate_J10008.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/60140/diff/5/ > > > Testing > ------- > > 1. Modified unit tests based on the new policy condition. > 2. Patched an existing cluster with the new service def changes and validated > that the new policy condition is shown for tag based policies. > > > Thanks, > > Sailaja Polavarapu > >
