-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60140/
-----------------------------------------------------------

(Updated June 19, 2017, 5:37 p.m.)


Review request for ranger, Abhay Kulkarni, Madhan Neethiraj, and Velmurugan 
Periasamy.


Changes
-------

Updated the service def based on the review comments as well as added the 
upgrade patch changes


Bugs: RANGER-1647
    https://issues.apache.org/jira/browse/RANGER-1647


Repository: ranger


Description
-------

Updated tag service def with new policy condition and also updated the unit 
tests to use tag attributes for policy condition.


Diffs (updated)
-----

  
agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerScriptConditionEvaluator.java
 48ffc38 
  
agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerScriptExecutionContext.java
 b0bba80 
  agents-common/src/main/resources/service-defs/ranger-servicedef-tag.json 
3bad222 
  agents-common/src/test/resources/policyengine/resourceTags.json 9523ca0 
  
agents-common/src/test/resources/policyengine/test_policyengine_tag_hive_filebased.json
 c2cb0b3 
  
security-admin/src/main/java/org/apache/ranger/patch/PatchForTagServiceDefUpdate_J10008.java
 PRE-CREATION 


Diff: https://reviews.apache.org/r/60140/diff/2/

Changes: https://reviews.apache.org/r/60140/diff/1-2/


Testing
-------

1. Modified unit tests based on the new policy condition.
2. Patched an existing cluster with the new service def changes and validated 
that the new policy condition is shown for tag based policies.


Thanks,

Sailaja Polavarapu

Reply via email to