----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60140/#review178510 -----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/patch/PatchForTagServiceDefUpdate_J10008.java Lines 134 (patched) <https://reviews.apache.org/r/60140/#comment252532> If line 129 is false, is it requird to proceed further? security-admin/src/main/java/org/apache/ranger/patch/PatchForTagServiceDefUpdate_J10008.java Lines 140 (patched) <https://reviews.apache.org/r/60140/#comment252533> Consider moving this check before checkScriptPolicyCondPresent() is called. If embeddedTagPolicyConditionDefs is null of if checkScript returns false, then setPolicyConditions() needs to be called. security-admin/src/main/java/org/apache/ranger/patch/PatchForTagServiceDefUpdate_J10008.java Lines 149 (patched) <https://reviews.apache.org/r/60140/#comment252534> Please check if updateServceDef fails and returns null instead of throwing exception. security-admin/src/main/java/org/apache/ranger/patch/PatchForTagServiceDefUpdate_J10008.java Lines 190 (patched) <https://reviews.apache.org/r/60140/#comment252535> Please consider this function to throw exception in case of errors instead of returning null. security-admin/src/main/java/org/apache/ranger/patch/PatchForTagServiceDefUpdate_J10008.java Lines 202 (patched) <https://reviews.apache.org/r/60140/#comment252538> By the time tag-service-def was supported, Ranger moved away from specifying service-def-options in a non-JSON format. So, this function may be simplified here. Consider throwing exception instead of returning null. It may simplify caller code also. - Abhay Kulkarni On June 20, 2017, 11:36 p.m., Sailaja Polavarapu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60140/ > ----------------------------------------------------------- > > (Updated June 20, 2017, 11:36 p.m.) > > > Review request for ranger, Abhay Kulkarni, Madhan Neethiraj, and Velmurugan > Periasamy. > > > Bugs: RANGER-1647 > https://issues.apache.org/jira/browse/RANGER-1647 > > > Repository: ranger > > > Description > ------- > > Updated tag service def with new policy condition and also updated the unit > tests to use tag attributes for policy condition. > > > Diffs > ----- > > > security-admin/src/main/java/org/apache/ranger/patch/PatchForTagServiceDefUpdate_J10008.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/60140/diff/4/ > > > Testing > ------- > > 1. Modified unit tests based on the new policy condition. > 2. Patched an existing cluster with the new service def changes and validated > that the new policy condition is shown for tag based policies. > > > Thanks, > > Sailaja Polavarapu > >
