----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61553/#review183413 -----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/patch/cliutil/RoleBaseUserSearchUtil.java Lines 48 (patched) <https://reviews.apache.org/r/61553/#comment259428> Add a unit test for this class? - Velmurugan Periasamy On Aug. 16, 2017, 11:49 a.m., Fatima Khan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61553/ > ----------------------------------------------------------- > > (Updated Aug. 16, 2017, 11:49 a.m.) > > > Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay > Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan > Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy. > > > Bugs: RANGER-1730 > https://issues.apache.org/jira/browse/RANGER-1730 > > > Repository: ranger > > > Description > ------- > > Actual : > Provide utility to list user according to role. > > Expected : > Utility to list users for the given role based on thier authorization > > > Diffs > ----- > > security-admin/scripts/rolebaseusersearchutil.py PRE-CREATION > > security-admin/src/main/java/org/apache/ranger/patch/cliutil/RoleBaseUserSearchUtil.java > PRE-CREATION > security-admin/src/main/java/org/apache/ranger/view/VXUserRole.java > PRE-CREATION > security-admin/src/main/java/org/apache/ranger/view/VXUserRoleList.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/61553/diff/1/ > > > Testing > ------- > > Tested on Simple against all roles > Tested on Secure against all roles > > > Thanks, > > Fatima Khan > >
