----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61553/#review185372 -----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/patch/cliutil/RoleBasedUserSearchUtil.java Lines 63 (patched) <https://reviews.apache.org/r/61553/#comment261695> name variables as userRole. Follow this pattern security-admin/src/main/java/org/apache/ranger/patch/cliutil/RoleBasedUserSearchUtil.java Lines 133 (patched) <https://reviews.apache.org/r/61553/#comment261684> Please Indent the methods to start at same position, check all the methods security-admin/src/main/java/org/apache/ranger/patch/cliutil/RoleBasedUserSearchUtil.java Lines 141 (patched) <https://reviews.apache.org/r/61553/#comment261686> Please use Apache CollectionUtils.isEmpty() if possible. Check all the other occurances of other similar checks security-admin/src/main/java/org/apache/ranger/patch/cliutil/RoleBasedUserSearchUtil.java Lines 206 (patched) <https://reviews.apache.org/r/61553/#comment261690> Please check if currentEncryptedPassword can be null? security-admin/src/main/java/org/apache/ranger/patch/cliutil/RoleBasedUserSearchUtil.java Lines 209 (patched) <https://reviews.apache.org/r/61553/#comment261691> can existingRole be null? Please verify security-admin/src/main/java/org/apache/ranger/patch/cliutil/RoleBasedUserSearchUtil.java Lines 217 (patched) <https://reviews.apache.org/r/61553/#comment261692> if UserRole is going to be not null do UserRole.equalsIgnoreCase(existingRole.get(0)). Verify similar check and correct it where ever needed. security-admin/src/main/java/org/apache/ranger/patch/cliutil/RoleBasedUserSearchUtil.java Lines 242 (patched) <https://reviews.apache.org/r/61553/#comment261682> Change this flag variable to "isUserAuthorized" security-admin/src/main/java/org/apache/ranger/patch/cliutil/RoleBasedUserSearchUtil.java Lines 247 (patched) <https://reviews.apache.org/r/61553/#comment261683> Authorized? - Ramesh Mani On Sept. 14, 2017, 4:33 a.m., Fatima Khan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61553/ > ----------------------------------------------------------- > > (Updated Sept. 14, 2017, 4:33 a.m.) > > > Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay > Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan > Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy. > > > Bugs: RANGER-1730 > https://issues.apache.org/jira/browse/RANGER-1730 > > > Repository: ranger > > > Description > ------- > > Actual : > Provide utility to list user according to role. > > Expected : > Utility to list users for the given role based on thier authorization > > > Diffs > ----- > > security-admin/scripts/rolebasedusersearchutil.py PRE-CREATION > > security-admin/src/main/java/org/apache/ranger/patch/cliutil/RoleBasedUserSearchUtil.java > PRE-CREATION > > security-admin/src/test/java/org/apache/ranger/patch/cliutil/TestRoleBasedUserSearchUtil.java > PRE-CREATION > src/main/assembly/admin-web.xml cb1aad2 > > > Diff: https://reviews.apache.org/r/61553/diff/3/ > > > Testing > ------- > > Tested on Simple against all roles > Tested on Secure against all roles > > > Thanks, > > Fatima Khan > >
