----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61553/#review183957 -----------------------------------------------------------
Fix it, then Ship it! security-admin/src/test/java/org/apache/ranger/patch/cliutil/TestRoleBaseUserSearchUtil.java Lines 46 (patched) <https://reviews.apache.org/r/61553/#comment260000> This patch fails the build on ranger-0.7 branch with the below error. Package org.mockito.junit (referenced in TestRoleBaseUserSearchUtil.java) does not exist in mockito 1.8.4 (ranger-0.7 uses 1.8.4 version, whereas master branch uses 2.7.22). This patch works fine for master branch. Can you create an updated patch for ranger-0.7? ``` [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.3:testCompile (default-testCompile) on project security-admin-web: Compilation failure: Compilation failure: [ERROR] /Users/vperiasamy/git/tlp-ranger/ranger-0.7/ranger/security-admin/src/test/java/org/apache/ranger/patch/cliutil/TestRoleBaseUserSearchUtil.java:[46,24] error: package org.mockito.junit does not exist [ERROR] /Users/vperiasamy/git/tlp-ranger/ranger-0.7/ranger/security-admin/src/test/java/org/apache/ranger/patch/cliutil/TestRoleBaseUserSearchUtil.java:[48,9] error: cannot find symbol ``` - Velmurugan Periasamy On Aug. 24, 2017, 4:31 a.m., Fatima Khan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61553/ > ----------------------------------------------------------- > > (Updated Aug. 24, 2017, 4:31 a.m.) > > > Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay > Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan > Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy. > > > Bugs: RANGER-1730 > https://issues.apache.org/jira/browse/RANGER-1730 > > > Repository: ranger > > > Description > ------- > > Actual : > Provide utility to list user according to role. > > Expected : > Utility to list users for the given role based on thier authorization > > > Diffs > ----- > > security-admin/scripts/rolebaseusersearchutil.py PRE-CREATION > > security-admin/src/main/java/org/apache/ranger/patch/cliutil/RoleBaseUserSearchUtil.java > PRE-CREATION > security-admin/src/main/java/org/apache/ranger/view/VXUserRole.java > PRE-CREATION > security-admin/src/main/java/org/apache/ranger/view/VXUserRoleList.java > PRE-CREATION > > security-admin/src/test/java/org/apache/ranger/patch/cliutil/TestRoleBaseUserSearchUtil.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/61553/diff/2/ > > > Testing > ------- > > Tested on Simple against all roles > Tested on Secure against all roles > > > Thanks, > > Fatima Khan > >
