> On Sept. 14, 2017, 6:12 a.m., Ramesh Mani wrote: > > security-admin/src/main/java/org/apache/ranger/patch/cliutil/RoleBasedUserSearchUtil.java > > Lines 217 (patched) > > <https://reviews.apache.org/r/61553/diff/3/?file=1820100#file1820100line217> > > > > if UserRole is going to be not null > > do UserRole.equalsIgnoreCase(existingRole.get(0)). Verify similar check > > and correct it where ever needed.
userRole is a utility parameter and it can be null. In the main method, i have checked it against not null and the flow is different for null and not null. UserRole.equalsIgnoreCase(existingRole.get(0)) will execute only when userRole is not null. - Fatima ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61553/#review185372 ----------------------------------------------------------- On Sept. 14, 2017, 4:33 a.m., Fatima Khan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61553/ > ----------------------------------------------------------- > > (Updated Sept. 14, 2017, 4:33 a.m.) > > > Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay > Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan > Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy. > > > Bugs: RANGER-1730 > https://issues.apache.org/jira/browse/RANGER-1730 > > > Repository: ranger > > > Description > ------- > > Actual : > Provide utility to list user according to role. > > Expected : > Utility to list users for the given role based on thier authorization > > > Diffs > ----- > > security-admin/scripts/rolebasedusersearchutil.py PRE-CREATION > > security-admin/src/main/java/org/apache/ranger/patch/cliutil/RoleBasedUserSearchUtil.java > PRE-CREATION > > security-admin/src/test/java/org/apache/ranger/patch/cliutil/TestRoleBasedUserSearchUtil.java > PRE-CREATION > src/main/assembly/admin-web.xml cb1aad2 > > > Diff: https://reviews.apache.org/r/61553/diff/3/ > > > Testing > ------- > > Tested on Simple against all roles > Tested on Secure against all roles > > > Thanks, > > Fatima Khan > >
