Copilot commented on code in PR #766:
URL: https://github.com/apache/ranger/pull/766#discussion_r2615572269
##########
plugin-ozone/pom.xml:
##########
@@ -145,9 +145,27 @@ limitations under the License.
<version>${org.bouncycastle.bcpkix-jdk18on}</version>
</dependency>
<dependency>
- <groupId>org.slf4j</groupId>
- <artifactId>log4j-over-slf4j</artifactId>
- <version>${slf4j.version}</version>
+ <groupId>org.junit.jupiter</groupId>
+ <artifactId>junit-jupiter-api</artifactId>
+ <version>${junit.jupiter.version}</version>
+ <scope>test</scope>
+ </dependency>
Review Comment:
The addition of JUnit Jupiter (JUnit 5) alongside the existing JUnit 4 tests
creates a mixed testing framework situation. Consider migrating all tests to
JUnit 5 for consistency, or add a comment explaining why both frameworks are
needed if there's a specific reason to maintain both.
```suggestion
</dependency>
<!--
The JUnit Vintage Engine is included to allow running legacy JUnit
4 tests
alongside JUnit 5 (Jupiter) tests. Remove this dependency once all
tests
have been migrated to JUnit 5.
-->
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
