spolavarpau1 commented on code in PR #766:
URL: https://github.com/apache/ranger/pull/766#discussion_r2621180143


##########
plugin-ozone/pom.xml:
##########
@@ -145,9 +145,21 @@ limitations under the License.
             <version>${org.bouncycastle.bcpkix-jdk18on}</version>
         </dependency>
         <dependency>
-            <groupId>org.slf4j</groupId>
-            <artifactId>log4j-over-slf4j</artifactId>

Review Comment:
   Any specific reason for removing slf4j dependency?



##########
agents-common/src/main/resources/service-defs/ranger-servicedef-ozone.json:
##########
@@ -64,7 +65,25 @@
                        "uiHint":"",
                        "label": "Ozone Key",
                        "description": "Ozone Key",
+                       "accessTypeRestrictions": [ "read", "write", "create", 
"list", "delete", "read_acl", "write_acl", "all" ],
                        "isValidLeaf": true
+               },
+               {
+                       "itemId":                 4,
+                       "name":                   "role",
+                       "type":                   "string",
+                       "level":                  10,

Review Comment:
   I am not very sure if the level is set to 10 intentionally to be same as 
that for volume.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to