Hi,

-1 binding as LICENSE is missing bundled 3rd party licenses

I checked:
- hashes and signatures fine
- LICENSE is missing 3rd party license information (see below)
- NOTICE is fine
- No unexpected binary files
- A couple of file are missing ASF headers [3][4]
- Can’t compile but may be my set up

License is missing mention of:
- these BSD licensed files [1]
- this file of unknown license (and it’s also missing a header) [2]
- these BSD style likened filed [5][6] shoes license is missing (so you not 
abiding with the terms of the license) and who probably incorrectly have ASF 
headers on them.

All of this issue were found by looking at the report Apache Rat produces.

It compile fine and is failing at the end of the build with this error:
[ 99%] Built target SyncProducer
[100%] Built target TransactionProducer
/usr/local/Cellar/cmake/3.4.3/bin/cmake -E cmake_progress_start 
/Users/justinmclean/ApacheRocketMQ/rocketmq-client-cpp-1.2.3-source-release/tmp_build_dir/CMakeFiles
 0
usage:  ar -d [-TLsv] archive file …
<snip>
cp: librocketmq.a: No such file or directory

But the file does exist in ./bin/librocketmq.a so perhaps it an issue with the 
build script on OSX?

It would be best to sign the release with an apache email address rather than 
[email protected]. 

Thanks,
Justin

1. /src/thread/disruptor/*
2. /src/message/BatchMessage.cpp
3. /.travis/check-git-clang-format.sh
4. /include/BatchMessage.h
5. /src/common/big_endian.cpp
6 /src/common/big_endian.h

Reply via email to