Cancel this vote due to some issues, after all the issues are fixed, the process will restart later. Issues and solutions attached in below mail thread.
At 2019-08-21 14:15:47, "Justin Mclean" <[email protected]> wrote: >Hi, > >-1 binding as LICENSE is missing bundled 3rd party licenses > >I checked: >- hashes and signatures fine >- LICENSE is missing 3rd party license information (see below) >- NOTICE is fine >- No unexpected binary files >- A couple of file are missing ASF headers [3][4] Yes, ASF header losts before. the ASF header is added to the files. see commitlog[1] >- Can’t compile but may be my set up > >License is missing mention of: >- these BSD licensed files [1] Metioned the BSD license in the project license file, see commitlog[1] >- this file of unknown license (and it’s also missing a header) [2] Add license header due to commitlog[1] >- these BSD style likened filed [5][6] shoes license is missing (so you not >abiding with the terms of the license) and who probably incorrectly have ASF >headers on them. Remove the the ASF Header and add metioned the BSD license in the license file, see commitlog[2] > >All of this issue were found by looking at the report Apache Rat produces. > >It compile fine and is failing at the end of the build with this error: >[ 99%] Built target SyncProducer >[100%] Built target TransactionProducer >/usr/local/Cellar/cmake/3.4.3/bin/cmake -E cmake_progress_start >/Users/justinmclean/ApacheRocketMQ/rocketmq-client-cpp-1.2.3-source-release/tmp_build_dir/CMakeFiles > 0 >usage: ar -d [-TLsv] archive file … ><snip> >cp: librocketmq.a: No such file or directory > >But the file does exist in ./bin/librocketmq.a so perhaps it an issue with the >build script on OSX? the ar command runs failed in MacOS, the script has been updated. as i checked in my build env, it compiled a static library OK. > >It would be best to sign the release with an apache email address rather than >[email protected]. the key of "BBC3FBA877D30832E2FBC8F901B994150CD1E262" was generated with my apache email "[email protected]" and send to the keserver "pgpkeys.mit.edu" before, and today, i have update it to the key server "keyserver.ubuntu.com" again. > >Thanks, >Justin > >1. /src/thread/disruptor/* >2. /src/message/BatchMessage.cpp >3. /.travis/check-git-clang-format.sh >4. /include/BatchMessage.h >5. /src/common/big_endian.cpp >6 /src/common/big_endian.h 1.https://github.com/apache/rocketmq-client-cpp/commit/b7821633d70d86db9db16405673f929937454ae2 2.https://github.com/apache/rocketmq-client-cpp/commit/8a2ed5a74182942803c743c3c7080234a2095291
