Maven, as is currently used in Royale, defaults to assuming the develop branch is of the release-version plus the SNAPSHOT suffix and defaults to removing the SNAPSHOT suffix in the release branch and advancing the develop version in the develop branch. It is all configurable, but probably easier on the RM if we use the defaults.
I'm sort of curious as to how/why Moonshine has expectations of nightly-build version numbers. What if Royale suddenly wanted to release every two weeks? Would that also break something in Moonshine if Moonshine could not also release every two weeks? Might be better if Moonshine used a redirectable URL to find the nightly. I'm also not sure how much Moonshine should encourage use of nightly builds so maybe that capability should evolve to be more like "use custom build" and accept a URL. My 2 cents, -Alex On 6/16/20, 9:22 AM, "Piotr Zarzycki" <[email protected]> wrote: I'm sorry Harbs. I've seen that but I didn't connect it with Moonshine at that moment. :( Thank you! On Tue, Jun 16, 2020, 6:06 PM Harbs <[email protected]> wrote: > We discussed the version number and I already suggested that we change the > number before release. No one objected before. That’s why I made the change. > > I reverted my commit fo now, so it should be back to 0.9.8 as soon as the > next build completes. FWIW, the version number has always been changed in > the develop branch immediately after release. > > I’m planning on discussing with Yishay and/or Alex starting the release > soon. Not sure the implications of changing the version in the release > branch vs. develop. > > > On Jun 16, 2020, at 5:42 PM, Piotr Zarzycki <[email protected]> > wrote: > > > > Harbs, > > > > You can use whatever you want number of version for release, but change > it > > once you release stuff not earlier - that's my point. It is not the > problem > > have 0.10.0 version of Royale for upcoming release at all. > > > > We are using hard coded url along with hard coded version in order to > > download Nightly build of Royale. Now you have changed it so 0.9.8 is not > > available obviously - our logic is failing and user is not able to > download > > Royale. > > > > Thanks, > > Piotr > > > > wt., 16 cze 2020 o 16:37 Harbs <[email protected]> napisał(a): > > > >> We can revert the bump, but I’m not sure it’s a great idea to set the > >> version in the release branch. It seems to me that the develop branch > >> should match the next release. > >> > >> If a version number of 0.10.0 breaks Moonshine, I think we should use > >> 0.9.8 for the next release. > >> > >> Although I’m not sure I understand why 0.10.0 breaks Moonshine. > >> > >>> On Jun 16, 2020, at 5:29 PM, Andrew Wetmore <[email protected]> > wrote: > >>> > >>> I support Piotr in this. We need to apply the number bump closer to > when > >>> the release will be available, rather than disrupting a very useful > >> partner > >>> application and its user community. > >>> > >>> a > >>> > >>> On Tue, Jun 16, 2020 at 11:10 AM Piotr Zarzycki < > >> [email protected]> > >>> wrote: > >>> > >>>> Hi Chris, > >>>> > >>>> You are right and I have mentioned in my previous email that we are > >>>> planning to fix that - it's going to happen probably in couple of > >> weeks. It > >>>> was not clear to you from the previous email ? > >>>> > >>>> I have asked Harbs for revert, cause I feel like it shouldn't be > >> increased > >>>> yet. Before he started to release it may have been days or weeks, > cause > >> non > >>>> of us is obligated to hold any kind of schedule towards the project. > It > >>>> ends up that our tool won't work during all of that time. > >>>> > >>>> Let's wait for some words from Harbs. > >>>> > >>>> Thanks, > >>>> Piotr > >>>> > >>>> wt., 16 cze 2020 o 16:03 Christofer Dutz <[email protected]> > >>>> napisał(a): > >>>> > >>>>> Hi all, > >>>>> > >>>>> just my few cents from the side-lines ... > >>>>> > >>>>> if the version bump from a release breaks something for an external > >> tool, > >>>>> I would probably consider that a problem with the tool, correct? > >>>>> > >>>>> Shouldn't the situation where a new version is being released sort of > >> be > >>>> a > >>>>> situation a tool can explicitly live with and the users shouldn't > have > >> to > >>>>> wait for this version to be explicitly supported? > >>>>> > >>>>> I so I would assume, if it downloads a nightly, it should probably > >> check > >>>>> the version and automatically use that. > >>>>> > >>>>> And after all Harbs did mention his plans to re-release pretty soon. > >>>>> > >>>>> Perhaps an increased release speed is even something that will help > >>>>> improve the overall tooling. > >>>>> > >>>>> Chris > >>>>> > >>>>> > >>>>> > >>>>> Am 16.06.20, 12:58 schrieb "Piotr Zarzycki" < > >> [email protected] > >>>>> : > >>>>> > >>>>> Hi Harbs, > >>>>> > >>>>> I think your changes in develop version to 0.10.0 is a bit > >> premature. > >>>>> Shouldn't you have done this during release process ? > >>>>> > >>>>> Your changes break our Moonshine SDK Installer [1] - which we have > >>>>> released > >>>>> one week ago with update where user can download newest released > and > >>>>> nightly build of Royale. Right now downloading nightly is not > >>>> possible > >>>>> through that - it's broken. > >>>>> We are planning for the next version have an ability to change > setup > >>>>> of SDK > >>>>> without need of releasing whole application, but this is still not > >>>>> implemented - if Royale stays with that version now we will need to > >>>>> make > >>>>> another release - I would like to avoid that effort. > >>>>> > >>>>> Would it be possible revert changes and make them once you start > >>>>> release > >>>>> process ? In fact even during release process this [2] - shouldn't > >>>>> change > >>>>> till release is done. > >>>>> > >>>>> [1] https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fmoonshine-ide.com%2Fdownload%2F%23moonshine-sdk-installer&data=02%7C01%7Caharui%40adobe.com%7Cfe2b355444f94fc16fa908d812117536%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C1%7C637279213476422745&sdata=P2EAgDDPTdBSMWk3QK%2F%2FqbMXiGtB0Wcu9LoSbsRsg7g%3D&reserved=0 > >>>>> [2] > >>>>> > >>>>> > >>>> > >> > https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapacheroyaleci2.westus2.cloudapp.azure.com%3A8080%2Fjob%2Froyale-asjs_jsonly%2F&data=02%7C01%7Caharui%40adobe.com%7Cfe2b355444f94fc16fa908d812117536%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C1%7C637279213476422745&sdata=7b6SQHsYRY6zJMLyiWMBQYLqQdiHk4RqX5ntXHhxvvc%3D&reserved=0 > >>>>> > >>>>> Thanks, > >>>>> Piotr > >>>>> > >>>>> wt., 2 cze 2020 o 19:45 Carlos Rovira <[email protected]> > >>>>> napisał(a): > >>>>> > >>>>>> +1 for 0.10.0 > >>>>>> > >>>>>> El mar., 2 jun. 2020 a las 17:53, Josh Tynjala (< > >>>>> [email protected] > >>>>>>> ) > >>>>>> escribió: > >>>>>> > >>>>>>> +1 on 0.10.0 > >>>>>>> > >>>>>>> -- > >>>>>>> Josh Tynjala > >>>>>>> Bowler Hat LLC <https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbowlerhat.dev%2F&data=02%7C01%7Caharui%40adobe.com%7Cfe2b355444f94fc16fa908d812117536%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C1%7C637279213476422745&sdata=URCvryBOOtfCKFvMvFlgSA2YkwevxjOEpFF4SLVmOZQ%3D&reserved=0> > >>>>>>> > >>>>>>> > >>>>>>> On Tue, Jun 2, 2020 at 5:36 AM Andrew Wetmore < > >>>> [email protected] > >>>>>> > >>>>>> wrote: > >>>>>>> > >>>>>>>> That's why I raised it now. I formally propose that, if this > >>>>> release > >>>>>>>> includes new functions or features, and is not just a bug fix, > >>>>> that we > >>>>>>> call > >>>>>>>> it "0.10.0", and that we follow that pattern for future > >>>> releases. > >>>>>>>> > >>>>>>>> a > >>>>>>>> > >>>>>>>> On Tue, Jun 2, 2020 at 9:04 AM Harbs <[email protected]> > >>>>> wrote: > >>>>>>>> > >>>>>>>>> I have no preference. > >>>>>>>>> > >>>>>>>>> If there’s a consensus on it being 0.10.0, that’s fine with > >>>> me, > >>>>>>> although > >>>>>>>>> it’ll probably be easiest if we make that change before we > >>>>> start on > >>>>>> the > >>>>>>>>> release. > >>>>>>>>> > >>>>>>>>> Harbs > >>>>>>>>> > >>>>>>>>>> On Jun 2, 2020, at 12:11 PM, Andrew Wetmore < > >>>>> [email protected]> > >>>>>>>> wrote: > >>>>>>>>>> > >>>>>>>>>> As Chris mentioned, will this release be 0.10.0? That is, > >>>>> does it > >>>>>> add > >>>>>>>>>> features and functions? Or is it a bug-fix release, and > >>>>> therefore > >>>>>>>> 0.9.8? > >>>>>>>>>> > >>>>>>>>>> a > >>>>>>>>>> > >>>>>>>>>> On Tue, Jun 2, 2020 at 5:47 AM Piotr Zarzycki < > >>>>>>>> [email protected] > >>>>>>>>>> > >>>>>>>>>> wrote: > >>>>>>>>>> > >>>>>>>>>>> Good luck! :) > >>>>>>>>>>> > >>>>>>>>>>> wt., 2 cze 2020 o 10:36 Harbs <[email protected]> > >>>>> napisał(a): > >>>>>>>>>>> > >>>>>>>>>>>> I intend to start on the next release early next week. > >>>>>>>>>>>> > >>>>>>>>>>>> I wanted to give folks a heads-up and time before I > >>>> start. > >>>>> If > >>>>>>> there’s > >>>>>>>>>>>> anything you have on your list to get done before our > >>>> next > >>>>>> release, > >>>>>>>> now > >>>>>>>>>>> is > >>>>>>>>>>>> the time. :-) > >>>>>>>>>>>> > >>>>>>>>>>>> Thanks, > >>>>>>>>>>>> Harbs > >>>>>>>>>>> > >>>>>>>>>>> > >>>>>>>>>>> > >>>>>>>>>>> -- > >>>>>>>>>>> > >>>>>>>>>>> Piotr Zarzycki > >>>>>>>>>>> > >>>>>>>>>>> Patreon: *https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7Cfe2b355444f94fc16fa908d812117536%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C1%7C637279213476422745&sdata=6xvyJf9FY33DzF1FJIFYuuzJUUj0v50wRu3slNqTFI4%3D&reserved=0 > >>>>>>>>>>> <https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7Cfe2b355444f94fc16fa908d812117536%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C1%7C637279213476422745&sdata=6xvyJf9FY33DzF1FJIFYuuzJUUj0v50wRu3slNqTFI4%3D&reserved=0>* > >>>>>>>>>>> > >>>>>>>>>> > >>>>>>>>>> > >>>>>>>>>> -- > >>>>>>>>>> Andrew Wetmore > >>>>>>>>>> > >>>>>>>>>> https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fcottage14.blogspot.com%2F&data=02%7C01%7Caharui%40adobe.com%7Cfe2b355444f94fc16fa908d812117536%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C1%7C637279213476422745&sdata=36kXz7OeoORKeMmja%2Bl5hnWTugQckmrGCjbdMicRy%2Fc%3D&reserved=0 > >>>>>>>>> > >>>>>>>>> > >>>>>>>> > >>>>>>>> -- > >>>>>>>> Andrew Wetmore > >>>>>>>> > >>>>>>>> https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fcottage14.blogspot.com%2F&data=02%7C01%7Caharui%40adobe.com%7Cfe2b355444f94fc16fa908d812117536%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C1%7C637279213476422745&sdata=36kXz7OeoORKeMmja%2Bl5hnWTugQckmrGCjbdMicRy%2Fc%3D&reserved=0 > >>>>>>>> > >>>>>>> > >>>>>> > >>>>>> > >>>>>> -- > >>>>>> Carlos Rovira > >>>>>> https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%7Cfe2b355444f94fc16fa908d812117536%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C1%7C637279213476422745&sdata=3Su6gdBUD1wUZLeVmv%2FHMBDrmHkYK0%2FVX3X15Rdq1sY%3D&reserved=0 > >>>>>> > >>>>> > >>>>> > >>>>> -- > >>>>> > >>>>> Piotr Zarzycki > >>>>> > >>>>> Patreon: *https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7Cfe2b355444f94fc16fa908d812117536%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C1%7C637279213476422745&sdata=6xvyJf9FY33DzF1FJIFYuuzJUUj0v50wRu3slNqTFI4%3D&reserved=0 > >>>>> <https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7Cfe2b355444f94fc16fa908d812117536%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C1%7C637279213476422745&sdata=6xvyJf9FY33DzF1FJIFYuuzJUUj0v50wRu3slNqTFI4%3D&reserved=0>* > >>>>> > >>>>> > >>>> > >>>> -- > >>>> > >>>> Piotr Zarzycki > >>>> > >>>> Patreon: *https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7Cfe2b355444f94fc16fa908d812117536%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C1%7C637279213476422745&sdata=6xvyJf9FY33DzF1FJIFYuuzJUUj0v50wRu3slNqTFI4%3D&reserved=0 > >>>> <https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7Cfe2b355444f94fc16fa908d812117536%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C1%7C637279213476422745&sdata=6xvyJf9FY33DzF1FJIFYuuzJUUj0v50wRu3slNqTFI4%3D&reserved=0>* > >>>> > >>> > >>> > >>> -- > >>> Andrew Wetmore > >>> > >>> https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fcottage14.blogspot.com%2F&data=02%7C01%7Caharui%40adobe.com%7Cfe2b355444f94fc16fa908d812117536%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C1%7C637279213476432701&sdata=3qG9LFTyvjKELVUsGU8SKM6iKzop7%2B6EGwE4yempf%2Bw%3D&reserved=0 > >> > >> > > > > -- > > > > Piotr Zarzycki > > > > Patreon: *https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7Cfe2b355444f94fc16fa908d812117536%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C1%7C637279213476432701&sdata=YhQ%2BZ%2FdYDmCL3XexGCjoiC%2BGKZfHKfafD7o41gaoxKo%3D&reserved=0 > > <https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7Cfe2b355444f94fc16fa908d812117536%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C1%7C637279213476432701&sdata=YhQ%2BZ%2FdYDmCL3XexGCjoiC%2BGKZfHKfafD7o41gaoxKo%3D&reserved=0>* > >
