[ 
https://issues.apache.org/jira/browse/S2GRAPH-117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15560384#comment-15560384
 ] 

Jong Wook Kim commented on S2GRAPH-117:
---------------------------------------

I did a survey on what other Apache projects are using:

|| Project || Started (roughly in) || Logging Framework ||
| Accumulo | 2012 | log4j |
| ActiveMQ | 2005 | log4j |
| Aurora | 2010 | logback |
| Avro | 2009 | slf4j-simple |
| Cassandra | 2008 | logback |
| Chukwa | 2008 | log4j |
| Curator | 2011 | log4j |
| Flink | 2010 | log4j |
| Flume | 2011 | log4j |
| Giraph | 2010 | log4j |
| Hadoop | 2006 | log4j |
| Hama | 2008 | log4j |
| HBase | 2007 | log4j |
| Hive | 2008 | log4j2 |
| Kafka | 2011 | log4j |
| Mina | 2005 | log4j2 |
| Oozie | 2011 | log4j |
| ORC | 2015 | log4j |
| Pig | 2009 | log4j |
| Samza | 2013 | log4j |
| Spark | 2010 | log4j |
| Storm | 2011 | log4j2 |
| Struts | 2006 | log4j2 |
| Tajo | 2011 | log4j |
| TinkerPop | 2013 | log4j |
| Zeppelin | 2013 | log4j |
| ZooKeeper | 2007 | log4j |

So while there's a couple using a non-log4j framework and some venturing 
log4j2, 

For now, all our apache dependencies (Hadoop, HBase, Spark) uses log4j 1.2, 
although in the long run we could make a transition to log4j2 later.

This leaves asynchbase and play framework that relies on logback, I'll first 
check if they *really* need logback and update on this thread.



> Cleaner logging library usage
> -----------------------------
>
>                 Key: S2GRAPH-117
>                 URL: https://issues.apache.org/jira/browse/S2GRAPH-117
>             Project: S2Graph
>          Issue Type: Improvement
>            Reporter: Jong Wook Kim
>             Fix For: 0.1.0
>
>   Original Estimate: 336h
>  Remaining Estimate: 336h
>
> Our SBT project is currently dependent on both log4j and logback, while using 
> two logging backends is not ideal.
> Furthermore, there has been report that in some configuration we have both 
> slf4j-log4j12 and log4j-over-slf4j in the classpath which leads to 
> StackOverflowError.
> The current codebase is not written with a clean usage of logging library in 
> mind, and I propose the following improvements to make our logging usage 
> conform with the de-facto standard of slf4j.
> - Figure out how the dependencies are using slf4j, log4j, and logback.
> - Use slf4j-api everywhere, named with the fully qualified class names.
> - Exclude slf4j backends from the library projects
> - Add either log4j or logback backends to the application projects, 
> preferably log4j.
> - Add a test case checking that the classpath has the correct configuration 
> of jars.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to