[
https://issues.apache.org/jira/browse/S2GRAPH-117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15563322#comment-15563322
]
Jong Wook Kim commented on S2GRAPH-117:
---------------------------------------
[~steamshon]: I was unable to reproduce the error.
The package should have all dependency JARs in the {{lib}} directory, so it
would be informative for us if you can check the version of {{netty-all}} JAR
in there.
When I removed the line added in S2GRAPH-120 after checking out the RC6 tag
from your docker image, {{netty-all}} is resolved to 4.0.33, which is older
than 4.0.40 and works just fine.
Do you remember which version of {{netty-all}} it was?
> Cleaner logging library usage
> -----------------------------
>
> Key: S2GRAPH-117
> URL: https://issues.apache.org/jira/browse/S2GRAPH-117
> Project: S2Graph
> Issue Type: Improvement
> Reporter: Jong Wook Kim
> Assignee: DOYUNG YOON
> Fix For: 0.1.0
>
> Original Estimate: 336h
> Remaining Estimate: 336h
>
> Our SBT project is currently dependent on both log4j and logback, while using
> two logging backends is not ideal.
> Furthermore, there has been report that in some configuration we have both
> slf4j-log4j12 and log4j-over-slf4j in the classpath which leads to
> StackOverflowError.
> The current codebase is not written with a clean usage of logging library in
> mind, and I propose the following improvements to make our logging usage
> conform with the de-facto standard of slf4j.
> - Figure out how the dependencies are using slf4j, log4j, and logback.
> - Use slf4j-api everywhere, named with the fully qualified class names.
> - Exclude slf4j backends from the library projects
> - Add either log4j or logback backends to the application projects,
> preferably log4j.
> - Add a test case checking that the classpath has the correct configuration
> of jars.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
