[
https://issues.apache.org/jira/browse/S2GRAPH-117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15561370#comment-15561370
]
ASF GitHub Bot commented on S2GRAPH-117:
----------------------------------------
GitHub user jongwook opened a pull request:
https://github.com/apache/incubator-s2graph/pull/88
[S2GRAPH-117] Use log4j exclusively, to avoid
Previously s2graph has been a mixture of log4j, logback, JCL, JUL and
commons-logging, because... Java :neutral_face:
In favor of using log4j via slf4j-api, these commits add specific
exclusions for the dependencies that mix up log4j, logback, etc.
Since Play framework 2.3 and 2.4 forces using logback while 2.5 does not, I
did a migration to Play 2.5.9 in order to use log4j in `s2rest_play` as well.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jongwook/incubator-s2graph S2GRAPH-117
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-s2graph/pull/88.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #88
----
commit 1f5cfde82145afc69f339ade698c06ea0e271f8a
Author: Jong Wook Kim <[email protected]>
Date: 2016-10-10T02:15:53Z
[S2GRAPH-117] cleaned up logging dependencies to use SLF4j-API only
commit c7967ff346e40ed6c27fe570931cc6defd87ffe8
Author: Jong Wook Kim <[email protected]>
Date: 2016-10-10T03:25:43Z
[S2GRAPH-117] migrated to play 2.4.8 (still emitting logback error)
commit fcb041b3cd14db591cd0cb868b118758ad70ad89
Author: Jong Wook Kim <[email protected]>
Date: 2016-10-10T04:13:12Z
[S2GRAPH-117] migrated to play 2.5.9
- explicitly set to not using dependency injection
- converted some Iteratees to Acumulators
commit 5b5b4334aa8c7075fc9a2c3a4bc607cad7c8c024
Author: Jong Wook Kim <[email protected]>
Date: 2016-10-10T05:34:06Z
[S2GRAPH-117] moved non-play tests to s2core
----
> Cleaner logging library usage
> -----------------------------
>
> Key: S2GRAPH-117
> URL: https://issues.apache.org/jira/browse/S2GRAPH-117
> Project: S2Graph
> Issue Type: Improvement
> Reporter: Jong Wook Kim
> Fix For: 0.1.0
>
> Original Estimate: 336h
> Remaining Estimate: 336h
>
> Our SBT project is currently dependent on both log4j and logback, while using
> two logging backends is not ideal.
> Furthermore, there has been report that in some configuration we have both
> slf4j-log4j12 and log4j-over-slf4j in the classpath which leads to
> StackOverflowError.
> The current codebase is not written with a clean usage of logging library in
> mind, and I propose the following improvements to make our logging usage
> conform with the de-facto standard of slf4j.
> - Figure out how the dependencies are using slf4j, log4j, and logback.
> - Use slf4j-api everywhere, named with the fully qualified class names.
> - Exclude slf4j backends from the library projects
> - Add either log4j or logback backends to the application projects,
> preferably log4j.
> - Add a test case checking that the classpath has the correct configuration
> of jars.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
