[
https://issues.apache.org/jira/browse/S2GRAPH-117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15562039#comment-15562039
]
DOYUNG YOON commented on S2GRAPH-117:
-------------------------------------
[~jongwook]
I have tested s2rest_play after merge this PR and I wondering if I missed
something.
{noformat}
Oops, cannot start the server.
io.netty.channel.ChannelException: Unable to create Channel from class class
io.netty.channel.socket.nio.NioServerSocketChannel
at
io.netty.bootstrap.AbstractBootstrap$BootstrapChannelFactory.newChannel(AbstractBootstrap.java:455)
at
io.netty.bootstrap.AbstractBootstrap.initAndRegister(AbstractBootstrap.java:306)
at
io.netty.bootstrap.AbstractBootstrap.doBind(AbstractBootstrap.java:271)
at io.netty.bootstrap.AbstractBootstrap.bind(AbstractBootstrap.java:235)
at play.core.server.NettyServer.bind(NettyServer.scala:139)
at
play.core.server.NettyServer.play$core$server$NettyServer$$bindChannel(NettyServer.scala:224)
at play.core.server.NettyServer$$anonfun$1.apply(NettyServer.scala:216)
at play.core.server.NettyServer$$anonfun$1.apply(NettyServer.scala:216)
at scala.Option.map(Option.scala:146)
at play.core.server.NettyServer.<init>(NettyServer.scala:216)
at
play.core.server.NettyServerProvider.createServer(NettyServer.scala:279)
at
play.core.server.NettyServerProvider.createServer(NettyServer.scala:278)
at
play.core.server.ServerProvider$class.createServer(ServerProvider.scala:25)
at
play.core.server.NettyServerProvider.createServer(NettyServer.scala:278)
at play.core.server.ProdServerStart$.start(ProdServerStart.scala:53)
at play.core.server.ProdServerStart$.main(ProdServerStart.scala:22)
at play.core.server.NettyServer$.main(NettyServer.scala:300)
at play.core.server.NettyServer.main(NettyServer.scala)
Caused by: java.lang.NoSuchMethodError:
io.netty.util.CharsetUtil.encoder(Ljava/nio/charset/Charset;)Ljava/nio/charset/CharsetEncoder;
at io.netty.buffer.ByteBufUtil.<clinit>(ByteBufUtil.java:61)
at io.netty.buffer.ByteBufAllocator.<clinit>(ByteBufAllocator.java:24)
at
io.netty.channel.DefaultChannelConfig.<init>(DefaultChannelConfig.java:53)
at
io.netty.channel.socket.DefaultServerSocketChannelConfig.<init>(DefaultServerSocketChannelConfig.java:45)
at
io.netty.channel.socket.nio.NioServerSocketChannel$NioServerSocketChannelConfig.<init>(NioServerSocketChannel.java:189)
at
io.netty.channel.socket.nio.NioServerSocketChannel$NioServerSocketChannelConfig.<init>(NioServerSocketChannel.java:187)
at
io.netty.channel.socket.nio.NioServerSocketChannel.<init>(NioServerSocketChannel.java:85)
at
io.netty.channel.socket.nio.NioServerSocketChannel.<init>(NioServerSocketChannel.java:70)
at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
at
sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
at
sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
at java.lang.Class.newInstance(Class.java:442)
at
io.netty.bootstrap.AbstractBootstrap$BootstrapChannelFactory.newChannel(AbstractBootstrap.java:453)
... 17 more
{noformat}
It seems like netty version is conflicting with higher play version.
Do you think we should override netty version on s2rest_play build.sbt?
> Cleaner logging library usage
> -----------------------------
>
> Key: S2GRAPH-117
> URL: https://issues.apache.org/jira/browse/S2GRAPH-117
> Project: S2Graph
> Issue Type: Improvement
> Reporter: Jong Wook Kim
> Assignee: DOYUNG YOON
> Fix For: 0.1.0
>
> Original Estimate: 336h
> Remaining Estimate: 336h
>
> Our SBT project is currently dependent on both log4j and logback, while using
> two logging backends is not ideal.
> Furthermore, there has been report that in some configuration we have both
> slf4j-log4j12 and log4j-over-slf4j in the classpath which leads to
> StackOverflowError.
> The current codebase is not written with a clean usage of logging library in
> mind, and I propose the following improvements to make our logging usage
> conform with the de-facto standard of slf4j.
> - Figure out how the dependencies are using slf4j, log4j, and logback.
> - Use slf4j-api everywhere, named with the fully qualified class names.
> - Exclude slf4j backends from the library projects
> - Add either log4j or logback backends to the application projects,
> preferably log4j.
> - Add a test case checking that the classpath has the correct configuration
> of jars.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
