Hi Eike On Fri, 2007-11-02 at 20:00 +0100, Eike Rathke wrote: > Hi Noel, > > So, in a calm minute now.. sorry for the long gap, that UI/feature > freeze nearing is always distracting ;) it's ok, I was off for a couple of day the end of last week anyway :-) only now catching up > .. > Looks strange indeed. As lcl_ScRange_Parse_XL_Header() is a subroutine > of lcl_ScRange_Parse_XL_A1() and lcl_ScRange_Parse_XL_R1C1() that may as > well be some internal precondition needed for the code following it,
> I didn't dive into that and whether those functions may return valid > range bits if in fact there was no range. sure, I wouldn't expect you would, I was hoping maybe you might have know why ;-) > I think that setting the flags > before really having encountered the condition they express may be > confusing (as we just have seen), given the complexity of the R1C1 case > it might ease things a lot though. Jody could tell ;-) calling Jody, calling Jody ( I will try to contact him ) > As the code > isn't executed in upstream OOo yet, your bug tracking system might > indicate whether there's something wrong with it and single references > being erroneously treated as ranges in some cases. As you pointed out the R1C1 cases are complicated, I hope to get some time to dig at this again > > > so I changed the routine ( once again ;-) ) while this uncertainty > > exists .... > > + if ( (nRes & SCA_VALID ) && nTmp1 && ( nTmp2 != > > nEndRangeBits ) ) > > + nRes |= ( nTmp1 << 4 ); > > + > > if ( (nRes & nMask) == nMask ) > > Append( aRange ); > > > > the above expects that a valid ( non-single ) case will have at least > > nEndRangeBits set - that I think is not an unreasonable assumption given > > ScRange::ParseAny tests the same bits in order to decide to try parsing > > an address. > > That should be fine. Good, I feel a more confident with the change then :-) > > > (p.s. I didn't forget about the suggestion for a define for 0x070f, it's > > just I don't want to trigger a ripple re-compile right now ) > > With ccache it takes just 30 minutes or so ;-) ;-) some day I am going to enable that config switch thanks again Eike Noel --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
