Hi Noel, On Tuesday, 2007-10-23 12:32:25 +0100, Noel Power wrote:
> yes you are right, I am just passing SCA_VALID as the nMask so I didn't > see this. Given if we change this there is a possibility that someone > somewhere depends on the full set of range flags being set > do you mean either > a) the client of ScRangeList::Parse must take care of this OR > b) ScRangeList::Parse should detect the single range was parsed by > ScRange::ParseAny and it should apply the remaining flags ( > SCA_VALID_COL2 | SCA_VALID_ROW2 | SCA_VALID_TAB2 ) OR Yes, that's what I meant. Of course apply them only if the corresponding bit is set for the single address as well. > c) ScRange::ParseAny should apply the extra flags it successfully > parses the string > > a) would mean finding every caller :-( Aren't that many, most just check for the SCA_VALID flag. > b) has some merit because it's an internal change > c) you could argue that if someone calls something called > ScRange::parseAny they would expect success to mean the full set of > flags to be set regardless of whether the range was formed from single > address or not Not necessarily. The parse methods return flags for what they parsed, and if that's just a single address ... You probably also don't want a sheet.a1 to expand to sheet.a1:sheet.a1 in case you use the flags to redisplay the range, so IMHO that should be under control of the caller. Eike -- OOo/SO Calc core developer. Number formatter stricken i18n transpositionizer. SunSign 0x87F8D412 : 2F58 5236 DB02 F335 8304 7D6C 65C9 F9B5 87F8 D412 OpenOffice.org Engineering at Sun: http://blogs.sun.com/GullFOSS Please don't send personal mail to this [EMAIL PROTECTED] account, which I use for mailing lists only and don't read from outside Sun. Use [EMAIL PROTECTED] Thanks.
pgp6NJZL0INPp.pgp
Description: PGP signature
