----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59241/#review174877 -----------------------------------------------------------
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java Lines 285 (patched) <https://reviews.apache.org/r/59241/#comment248104> It is better to capitalize as metastoreURI. Should we also check for isEmoty()? We discovered before that initially (during tests) it is empty but later may become non-empty - why this isn't an issue any more? sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java Lines 319 (patched) <https://reviews.apache.org/r/59241/#comment248105> Please don't depend on this here, but depend on known object state (e.g. hmsFollower being null). - Alexander Kolbasov On May 12, 2017, 7:49 p.m., Na Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59241/ > ----------------------------------------------------------- > > (Updated May 12, 2017, 7:49 p.m.) > > > Review request for sentry, Alexander Kolbasov, Brian Towles, Hao Hao, kalyan > kumar kalvagadda, and Sergio Pena. > > > Bugs: SENTRY-1705 > https://issues.apache.org/jira/browse/SENTRY-1705 > > > Repository: sentry > > > Description > ------- > > check if metastore uri is configured or not. If not, don't create HMSFollower. > > This code change is base on assumption that code change in > https://reviews.apache.org/r/59120/diff/5#1 is checked in (hive configuration > is available when sentry server starts). Otherwise, it may break tests since > in test, hive configuration is not available when sentry server starts. > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java > 6fb224c > > > Diff: https://reviews.apache.org/r/59241/diff/1/ > > > Testing > ------- > > > Thanks, > > Na Li > >
