> On May 13, 2017, 1:15 a.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java > > Lines 285 (patched) > > <https://reviews.apache.org/r/59241/diff/1/?file=1717148#file1717148line285> > > > > It is better to capitalize as metastoreURI. > > Should we also check for isEmoty()? > > > > We discovered before that initially (during tests) it is empty but > > later may become non-empty - why this isn't an issue any more?
This change depends on checking in sentry-1757. After that, the order to create services in test has changed to be similar to the production. So when sentry service starts, the configuration is already available. Then if the metaStoreURI is null, it means hive configuration at sentry is not present > On May 13, 2017, 1:15 a.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java > > Lines 319 (patched) > > <https://reviews.apache.org/r/59241/diff/1/?file=1717148#file1717148line319> > > > > Please don't depend on this here, but depend on known object state > > (e.g. hmsFollower being null). I will check if they are both null. If so, skip the following processing - Na ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59241/#review174877 ----------------------------------------------------------- On May 12, 2017, 7:49 p.m., Na Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59241/ > ----------------------------------------------------------- > > (Updated May 12, 2017, 7:49 p.m.) > > > Review request for sentry, Alexander Kolbasov, Brian Towles, Hao Hao, kalyan > kumar kalvagadda, and Sergio Pena. > > > Bugs: SENTRY-1705 > https://issues.apache.org/jira/browse/SENTRY-1705 > > > Repository: sentry > > > Description > ------- > > check if metastore uri is configured or not. If not, don't create HMSFollower. > > This code change is base on assumption that code change in > https://reviews.apache.org/r/59120/diff/5#1 is checked in (hive configuration > is available when sentry server starts). Otherwise, it may break tests since > in test, hive configuration is not available when sentry server starts. > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java > 6fb224c > > > Diff: https://reviews.apache.org/r/59241/diff/1/ > > > Testing > ------- > > > Thanks, > > Na Li > >
