----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59241/#review175452 -----------------------------------------------------------
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java Line 137 (original), 136 (patched) <https://reviews.apache.org/r/59241/#comment248901> We already have this check in SentryService - we shouldn't even be here if it isn't present so why do we need to check it here? sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java Lines 324 (patched) <https://reviews.apache.org/r/59241/#comment248903> So we no longer have the situation where metastore URI isn't present initially but later becomes available? - Alexander Kolbasov On May 18, 2017, 9:04 p.m., Na Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59241/ > ----------------------------------------------------------- > > (Updated May 18, 2017, 9:04 p.m.) > > > Review request for sentry, Alexander Kolbasov, Brian Towles, Hao Hao, kalyan > kumar kalvagadda, and Sergio Pena. > > > Bugs: SENTRY-1705 > https://issues.apache.org/jira/browse/SENTRY-1705 > > > Repository: sentry > > > Description > ------- > > check if metastore uri is configured or not. If not, don't create HMSFollower. > > This code change is base on assumption that code change in > https://reviews.apache.org/r/59120/diff/5#1 is checked in (hive configuration > is available when sentry server starts). Otherwise, it may break tests since > in test, hive configuration is not available when sentry server starts. > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > 5dc0ad3 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java > 35289aa > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryServiceUtil.java > 9470437 > > > Diff: https://reviews.apache.org/r/59241/diff/3/ > > > Testing > ------- > > > Thanks, > > Na Li > >
