----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59241/#review174958 -----------------------------------------------------------
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java Lines 283-288 (patched) <https://reviews.apache.org/r/59241/#comment248262> This block is also used on stopHMSFollower. Should we create a method to check this? Some like SentryServiceUtil.isHiveMetastoreURISet()? or something like that. - Sergio Pena On May 15, 2017, 3:52 p.m., Na Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59241/ > ----------------------------------------------------------- > > (Updated May 15, 2017, 3:52 p.m.) > > > Review request for sentry, Alexander Kolbasov, Brian Towles, Hao Hao, kalyan > kumar kalvagadda, and Sergio Pena. > > > Bugs: SENTRY-1705 > https://issues.apache.org/jira/browse/SENTRY-1705 > > > Repository: sentry > > > Description > ------- > > check if metastore uri is configured or not. If not, don't create HMSFollower. > > This code change is base on assumption that code change in > https://reviews.apache.org/r/59120/diff/5#1 is checked in (hive configuration > is available when sentry server starts). Otherwise, it may break tests since > in test, hive configuration is not available when sentry server starts. > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java > 6fb224c > > > Diff: https://reviews.apache.org/r/59241/diff/2/ > > > Testing > ------- > > > Thanks, > > Na Li > >
