seanyinx commented on a change in pull request #114: SCB-227 stop sub tx from
running when global tx failed
URL:
https://github.com/apache/incubator-servicecomb-saga/pull/114#discussion_r161417342
##########
File path:
omega/omega-connector/omega-connector-grpc/src/main/java/org/apache/servicecomb/saga/omega/connector/grpc/GrpcClientMessageSender.java
##########
@@ -83,8 +84,9 @@ public String target() {
}
@Override
- public void send(TxEvent event) {
- blockingEventService.onTxEvent(convertEvent(event));
+ public boolean send(TxEvent event) {
+ GrpcAck grpcAck = blockingEventService.onTxEvent(convertEvent(event));
+ return grpcAck.getValid();
Review comment:
better to return a proper AlphaResponse class instead of boolean
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services