seanyinx commented on a change in pull request #114: SCB-227 stop sub tx from 
running when global tx failed
URL: 
https://github.com/apache/incubator-servicecomb-saga/pull/114#discussion_r161417220
 
 

 ##########
 File path: pack-contracts/pack-contract-grpc/src/main/proto/GrpcTxEvent.proto
 ##########
 @@ -33,6 +33,7 @@ message GrpcServiceConfig {
 }
 
 message GrpcAck {
+  bool valid = 1;
 
 Review comment:
   valid doesn't seem to be a proper name, because the transaction is indeed 
valid. probably just `aborted`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to