seanyinx commented on a change in pull request #114: SCB-227 stop sub tx from 
running when global tx failed
URL: 
https://github.com/apache/incubator-servicecomb-saga/pull/114#discussion_r161444593
 
 

 ##########
 File path: 
alpha/alpha-server/src/main/java/org/apache/servicecomb/saga/alpha/server/GrpcTxEventEndpointImpl.java
 ##########
 @@ -85,7 +87,12 @@ public void onTxEvent(GrpcTxEvent message, 
StreamObserver<GrpcAck> responseObser
         message.getPayloads().toByteArray()
     ));
 
-    responseObserver.onNext(ACK);
+    if (ok) {
 
 Review comment:
   this can be simplified into one line

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to