seanyinx commented on a change in pull request #114: SCB-227 stop sub tx from 
running when global tx failed
URL: 
https://github.com/apache/incubator-servicecomb-saga/pull/114#discussion_r161443701
 
 

 ##########
 File path: 
omega/omega-connector/omega-connector-grpc/src/main/java/org/apache/servicecomb/saga/omega/connector/grpc/LoadBalancedClusterMessageSender.java
 ##########
 @@ -124,14 +125,15 @@ public void close() {
   }
 
   @Override
-  public void send(TxEvent event) {
+  public AlphaResponse send(TxEvent event) {
+    AlphaResponse response = null;
 
 Review comment:
   have to think about when this response will be returned, and the consequence 
of returning this response under such a scenario. apparently it's only possible 
when this thread is interrupted and throwing an exception is a better idea in 
such case.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to