http://codereview.appspot.com/3348041/diff/1/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandler.java File java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandler.java (right):
http://codereview.appspot.com/3348041/diff/1/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandler.java#newcode537 java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandler.java:537: this.debug= getBooleanParam(request, "debug"); supernit: space before = http://codereview.appspot.com/3348041/diff/1/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerApi.java File java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerApi.java (right): http://codereview.appspot.com/3348041/diff/1/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerApi.java#newcode188 java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerApi.java:188: public List<String> getDirectives(); (I'll probably see in the next file or two) What are these directives? General purpose question, any value in making this more well-structured? http://codereview.appspot.com/3348041/diff/1/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerApi.java#newcode194 java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerApi.java:194: public List<String> getMessages(); FMI any better structure we can provide to this? Specifically: * Type [lint, error, warning, etc] * Line # info http://codereview.appspot.com/3348041/diff/1/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java File java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java (right): http://codereview.appspot.com/3348041/diff/1/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java#newcode267 java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java:267: throw new ProcessingException("Missing container paramater", HttpResponse.SC_BAD_REQUEST); s/paramater/parameter/ http://codereview.appspot.com/3348041/diff/1/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java#newcode274 java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java:274: } all these 3 checks could just use verifyBaseParams(request, true) http://codereview.appspot.com/3348041/diff/1/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java#newcode281 java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java:281: request.getMimeType(), !request.getDirectives().contains("valija"), request.getDebug()); My understanding is that the cajita/valija distinction is going away, and sooner than later. Assuming this is so, we should just get rid of this directive's support. http://codereview.appspot.com/3348041/
