Dunno personally if there's a hard-and-fast rule on this convention; I have a minor personal preference to fix it at true to ensure we're always on ES53 w/r/t to the Caja API.
On Thu, Dec 2, 2010 at 11:31 AM, <[email protected]> wrote: > > > http://codereview.appspot.com/3348041/diff/7001/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerTest.java > File > > java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerTest.java > (right): > > > http://codereview.appspot.com/3348041/diff/7001/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerTest.java#newcode211 > > java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerTest.java:211: > EasyMock.anyBoolean(), > It is. I was unsure of test convention - the particular test would hold > even if those were false though which is why I went with anyBoolean. > > Happy to change it. > > On 2010/12/02 19:23:05, johnfargo wrote: > >> isn't this always "true"? >> > > http://codereview.appspot.com/3348041/ >
