http://codereview.appspot.com/3348041/diff/17001/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/CajaContentRewriter.java
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/CajaContentRewriter.java
(right):

http://codereview.appspot.com/3348041/diff/17001/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/CajaContentRewriter.java#newcode159
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/CajaContentRewriter.java:159:
CharProducer cp = fetcher.fetch(extRef, mime).getTextualContent();
Do we care about response code or any other header information
(encoding?)
Do we care if fetch failed?

http://codereview.appspot.com/3348041/diff/17001/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/CajaContentRewriter.java#newcode297
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/CajaContentRewriter.java:297:
@VisibleForTesting
Did you create more tests that are not attached?

http://codereview.appspot.com/3348041/diff/17001/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandler.java
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandler.java
(right):

http://codereview.appspot.com/3348041/diff/17001/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandler.java#newcode82
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandler.java:82:
private static final List<String> DEFAULT_CAJA_FIELDS =
ImmutableList.of("html", "js", "messages");
Just use "*" :)

http://codereview.appspot.com/3348041/diff/17001/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerApi.java
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerApi.java
(right):

http://codereview.appspot.com/3348041/diff/17001/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerApi.java#newcode187
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerApi.java:187:
public boolean getDebug();
Not sure who is the user but I can see for consistency to support also
getIgnoreCache() and getRefresh()
(maybe add a comment that indicate the base url is used for the resource
to cajoled)

http://codereview.appspot.com/3348041/diff/17001/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java
(right):

http://codereview.appspot.com/3348041/diff/17001/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java#newcode56
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java:56:
import
org.apache.shindig.gadgets.servlet.GadgetsHandlerApi.MessageLevel;
I know it won't leave for long...
but so far I tried to use the name GadgetHandlerApi namespace for all
Api classes when used. So maybe take out the sub classes import.

http://codereview.appspot.com/3348041/diff/17001/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java#newcode105
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java:105:
.put(GadgetsHandlerApi.RenderingContext.class, RenderingContext.class)
To support validation add
  .put(CajaMessageLevel.class, GadgetHandlerApi.MessageLevel.class)

http://codereview.appspot.com/3348041/diff/17001/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java#newcode287
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java:287:
m.format(mc), convertMessageLevel(m.getMessageLevel().name()));
You can use beanDelegator to do this conversion which will also give a
test failure if the enums don't match.
beanDelegator(m.getMessageLevel(), GadgetHandlerApi.MessageLevel.class,
null)

http://codereview.appspot.com/3348041/diff/17001/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java#newcode325
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java:325:
timeSource.currentTimeMillis() + specRefreshInterval);
Do you really want the same expiration logic as gadget spec?
I would think that the proxy expiration logic would be better (use
HttpResponse expiration time).
You can put a TODO for later improvement.

http://codereview.appspot.com/3348041/

Reply via email to