http://codereview.appspot.com/3348041/diff/17001/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/CajaContentRewriter.java
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/CajaContentRewriter.java
(right):

http://codereview.appspot.com/3348041/diff/17001/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/CajaContentRewriter.java#newcode159
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/CajaContentRewriter.java:159:
CharProducer cp = fetcher.fetch(extRef, mime).getTextualContent();
If the fetch fails, the failure is reported as part of the serialization
of the message queue.  Added a comment to that effect.

On 2010/12/02 21:23:13, zhoresh wrote:
Do we care about response code or any other header information
(encoding?)
Do we care if fetch failed?

http://codereview.appspot.com/3348041/diff/17001/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/CajaContentRewriter.java#newcode297
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/CajaContentRewriter.java:297:
@VisibleForTesting
Reverted.

On 2010/12/02 21:23:13, zhoresh wrote:
Did you create more tests that are not attached?

http://codereview.appspot.com/3348041/diff/17001/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandler.java
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandler.java
(right):

http://codereview.appspot.com/3348041/diff/17001/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandler.java#newcode82
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandler.java:82:
private static final List<String> DEFAULT_CAJA_FIELDS =
ImmutableList.of("html", "js", "messages");
On 2010/12/02 21:23:13, zhoresh wrote:
Just use "*" :)

Done.

http://codereview.appspot.com/3348041/diff/17001/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerApi.java
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerApi.java
(right):

http://codereview.appspot.com/3348041/diff/17001/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerApi.java#newcode187
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerApi.java:187:
public boolean getDebug();
As the CL stands, no caching is done.  Marked this as TODO.

On 2010/12/02 21:23:13, zhoresh wrote:
Not sure who is the user but I can see for consistency to support also
getIgnoreCache() and getRefresh()
(maybe add a comment that indicate the base url is used for the
resource to
cajoled)

http://codereview.appspot.com/3348041/diff/17001/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java
(right):

http://codereview.appspot.com/3348041/diff/17001/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java#newcode105
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java:105:
.put(GadgetsHandlerApi.RenderingContext.class, RenderingContext.class)
See below.

On 2010/12/02 21:23:13, zhoresh wrote:
To support validation add
   .put(CajaMessageLevel.class, GadgetHandlerApi.MessageLevel.class)

http://codereview.appspot.com/3348041/diff/17001/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java#newcode287
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java:287:
m.format(mc), convertMessageLevel(m.getMessageLevel().name()));
I ran into errors using beanDelegator the way you suggest.  I've marked
this as a TODO.

On 2010/12/02 21:23:13, zhoresh wrote:
You can use beanDelegator to do this conversion which will also give a
test
failure if the enums don't match.
beanDelegator(m.getMessageLevel(),
GadgetHandlerApi.MessageLevel.class, null)

http://codereview.appspot.com/3348041/diff/17001/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java#newcode325
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java:325:
timeSource.currentTimeMillis() + specRefreshInterval);
On 2010/12/02 21:23:13, zhoresh wrote:
Do you really want the same expiration logic as gadget spec?
I would think that the proxy expiration logic would be better (use
HttpResponse
expiration time).
You can put a TODO for later improvement.

Done.

http://codereview.appspot.com/3348041/

Reply via email to