----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1533/#review1512 -----------------------------------------------------------
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/ConServContainer.js <https://reviews.apache.org/r/1533/#comment3460> Is it possible for actions not to have any items in it? http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/ConServContainer.js <https://reviews.apache.org/r/1533/#comment3461> Is it possible for actions not to have actions in it? http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/ConServContainer.js <https://reviews.apache.org/r/1533/#comment3455> Small nit would be nice to add a comment there, the rest of the code is nicely commented http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/sample-actions-runner.xml <https://reviews.apache.org/r/1533/#comment3462> Can we add show and hide action listeners to the sample? http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions.js <https://reviews.apache.org/r/1533/#comment3456> The function is called registerShowActionListener in the spec http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions.js <https://reviews.apache.org/r/1533/#comment3457> Same here the function is called registerHidActionsListener http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js <https://reviews.apache.org/r/1533/#comment3458> This is invalid, put takes 2 parameters. Maybe you meant for showActionListeners to be an array? http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js <https://reviews.apache.org/r/1533/#comment3459> Same here put takes 2 parameters - Ryan On 2011-08-16 19:17:05, Matthew Hatem wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1533/ > ----------------------------------------------------------- > > (Updated 2011-08-16 19:17:05) > > > Review request for shindig and Ryan Baxter. > > > Summary > ------- > > Fixes to actions feature to match spec (runAction and registerXHandler). > > JIRA posted: > https://issues.apache.org/jira/browse/SHINDIG-1575 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/ConServContainer.js > 1157952 > > http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/index.html > 1157952 > > http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/sample-actions-runner.xml > PRE-CREATION > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions.js > 1157952 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js > 1157952 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/feature.xml > 1157952 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/taming.js > 1157952 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/actions/actions_test.js > 1157952 > > Diff: https://reviews.apache.org/r/1533/diff > > > Testing > ------- > > All JsUnit tests pass > > > Thanks, > > Matthew > >
