> On 2011-08-17 22:14:53, Ryan Baxter wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions.js, > > line 251 > > <https://reviews.apache.org/r/1533/diff/2/?file=32940#file32940line251> > > > > Same here the function is called registerHidActionsListener > > Matthew Hatem wrote: > The Core Gadget spec is wrong and inconsistent. The API should be > symmetric with the CommonContainer API which uses 'Handler' not 'Listener'. > > Also, the examples in the Core Gadget spec uses 'Handler' > > var myShowActionsHandler = function(actionObjs){ > // draw the UI, toolbars menus, etc > // to do the invocation of the action, call the following API: > // gadgets.actions.runAction(actionObjs[0].id); > } > gadgets.actions.registerShowActionsHandler(myShowActionHandler); > > Henry Saputra wrote: > So either we change the spec or change this code to match the spec. Even > though its maybe wrong but thats what in the final spec. > > I would prefer to have it wrong here to at least match the spec. From > gadgets point of view I think its ok to be called xxxListener because it > listen actions event from container.
I would prefer to change the spec but I understand if it's too late. I can change 'Handler' to 'Listener' now. Should I create a defect to update the example code in the spec. - Matthew ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1533/#review1512 ----------------------------------------------------------- On 2011-08-19 13:56:41, Matthew Hatem wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1533/ > ----------------------------------------------------------- > > (Updated 2011-08-19 13:56:41) > > > Review request for shindig and Ryan Baxter. > > > Summary > ------- > > Fixes to actions feature to match spec (runAction and registerXHandler). > > JIRA posted: > https://issues.apache.org/jira/browse/SHINDIG-1575 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/ConServContainer.js > 1157952 > > http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/index.html > 1157952 > > http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/sample-actions-runner.xml > PRE-CREATION > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions.js > 1157952 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js > 1157952 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/feature.xml > 1157952 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/taming.js > 1157952 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/actions/actions_test.js > 1157952 > > Diff: https://reviews.apache.org/r/1533/diff > > > Testing > ------- > > All JsUnit tests pass > > > Thanks, > > Matthew > >
