> On 2011-08-17 22:14:53, Ryan Baxter wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/ConServContainer.js, > > line 90 > > <https://reviews.apache.org/r/1533/diff/2/?file=32937#file32937line90> > > > > Is it possible for actions not to have any items in it?
no > On 2011-08-17 22:14:53, Ryan Baxter wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/ConServContainer.js, > > line 174 > > <https://reviews.apache.org/r/1533/diff/2/?file=32937#file32937line174> > > > > Is it possible for actions not to have actions in it? no > On 2011-08-17 22:14:53, Ryan Baxter wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/ConServContainer.js, > > line 199 > > <https://reviews.apache.org/r/1533/diff/2/?file=32937#file32937line199> > > > > Small nit would be nice to add a comment there, the rest of the code is > > nicely commented done. > On 2011-08-17 22:14:53, Ryan Baxter wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions.js, > > line 251 > > <https://reviews.apache.org/r/1533/diff/2/?file=32940#file32940line251> > > > > Same here the function is called registerHidActionsListener The Core Gadget spec is wrong and inconsistent. The API should be symmetric with the CommonContainer API which uses 'Handler' not 'Listener'. Also, the examples in the Core Gadget spec uses 'Handler' var myShowActionsHandler = function(actionObjs){ // draw the UI, toolbars menus, etc // to do the invocation of the action, call the following API: // gadgets.actions.runAction(actionObjs[0].id); } gadgets.actions.registerShowActionsHandler(myShowActionHandler); > On 2011-08-17 22:14:53, Ryan Baxter wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js, > > line 561 > > <https://reviews.apache.org/r/1533/diff/2/?file=32941#file32941line561> > > > > This is invalid, put takes 2 parameters. Maybe you meant for > > showActionListeners to be an array? should be push(), sorry > On 2011-08-17 22:14:53, Ryan Baxter wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js, > > line 584 > > <https://reviews.apache.org/r/1533/diff/2/?file=32941#file32941line584> > > > > Same here put takes 2 parameters should be push(), sorry - Matthew ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1533/#review1512 ----------------------------------------------------------- On 2011-08-16 19:17:05, Matthew Hatem wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1533/ > ----------------------------------------------------------- > > (Updated 2011-08-16 19:17:05) > > > Review request for shindig and Ryan Baxter. > > > Summary > ------- > > Fixes to actions feature to match spec (runAction and registerXHandler). > > JIRA posted: > https://issues.apache.org/jira/browse/SHINDIG-1575 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/ConServContainer.js > 1157952 > > http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/index.html > 1157952 > > http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/sample-actions-runner.xml > PRE-CREATION > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions.js > 1157952 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js > 1157952 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/feature.xml > 1157952 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/taming.js > 1157952 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/actions/actions_test.js > 1157952 > > Diff: https://reviews.apache.org/r/1533/diff > > > Testing > ------- > > All JsUnit tests pass > > > Thanks, > > Matthew > >
