[
https://issues.apache.org/jira/browse/SINGA-21?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14730590#comment-14730590
]
ASF subversion and git services commented on SINGA-21:
------------------------------------------------------
Commit 134c891abf07b28ed75c2ee403d4698164c12c3e in incubator-singa's branch
refs/heads/master from wang sheng
[ https://git-wip-us.apache.org/repos/asf?p=incubator-singa.git;h=134c891 ]
SINGA-21 Code review 4
review base_layer.h/cc, layer.h/cc, optional_layer.h/cc
- change basic functions in Layer from virtual to inline
- make ComputeFeature and ComputeGradient have same paramters
i.e. ComputeGradient(Phase phase, Metric* perf)
- add a middle level of layer category for ConnectionLayer and NeuronLayer
- re-arrange Layers in these file
base_layer.h contains layer categories that are extended by other layers
layer.h contains layer implementations
> Code Review
> -----------
>
> Key: SINGA-21
> URL: https://issues.apache.org/jira/browse/SINGA-21
> Project: Singa
> Issue Type: Task
> Reporter: Sheng Wang
> Assignee: Sheng Wang
>
> Clean the code for first release.
> Code style follows google c++ code
> style(https://google-styleguide.googlecode.com/svn/trunk/cppguide.html).
> Style check tool
> cpplint(http://google-styleguide.googlecode.com/svn/trunk/cpplint/cpplint.py)
> is recommanded to help clean the code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
