[
https://issues.apache.org/jira/browse/SINGA-21?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14904621#comment-14904621
]
ASF subversion and git services commented on SINGA-21:
------------------------------------------------------
Commit 0c6e5c692bb07b481baca004b07b08b2a0601c6e in incubator-singa's branch
refs/heads/master from [~flytosky]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-singa.git;h=0c6e5c6 ]
SINGA-21 Code review 5
Move the implementation of template functions back to driver.h from driver.cc.
Otherwise there would be link errors when users register their own classes.
Because the registration functions are instantiated during compiling the
user code. diriver.h must contain the declarations and the
implementations of these template functions to instantiate them for users
classes.
> Code Review
> -----------
>
> Key: SINGA-21
> URL: https://issues.apache.org/jira/browse/SINGA-21
> Project: Singa
> Issue Type: Task
> Reporter: Sheng Wang
> Assignee: Sheng Wang
>
> Clean the code for first release.
> Code style follows google c++ code
> style(https://google-styleguide.googlecode.com/svn/trunk/cppguide.html).
> Style check tool
> cpplint(http://google-styleguide.googlecode.com/svn/trunk/cpplint/cpplint.py)
> is recommanded to help clean the code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
