[
https://issues.apache.org/jira/browse/SINGA-21?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14904619#comment-14904619
]
ASF subversion and git services commented on SINGA-21:
------------------------------------------------------
Commit f50d293ff550d5b8ccace9f7e6992865474d0d29 in incubator-singa's branch
refs/heads/master from wang sheng
[ https://git-wip-us.apache.org/repos/asf?p=incubator-singa.git;h=f50d293 ]
SINGA-21 Code review 5
review worker.h, worker.cc
- format code
- change shared_ptr to raw ptr for neuralnet object
all neuralnet object will be managed by trainer
trainer passes pointers to workers and releases them in destructor
others
- remove virtual keyword in Server class (server.h)
> Code Review
> -----------
>
> Key: SINGA-21
> URL: https://issues.apache.org/jira/browse/SINGA-21
> Project: Singa
> Issue Type: Task
> Reporter: Sheng Wang
> Assignee: Sheng Wang
>
> Clean the code for first release.
> Code style follows google c++ code
> style(https://google-styleguide.googlecode.com/svn/trunk/cppguide.html).
> Style check tool
> cpplint(http://google-styleguide.googlecode.com/svn/trunk/cpplint/cpplint.py)
> is recommanded to help clean the code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
