kwin commented on a change in pull request #4:
URL:
https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/pull/4#discussion_r757623805
##########
File path: pom.xml
##########
@@ -180,7 +167,7 @@
<artifactId>maven-shade-plugin</artifactId>
<configuration>
<!--
- embed all jackrabbit artifacts to prevent classpath
clashes
+ embed all jackrabbit artifacts, to prevent classpath
clashes
Review comment:
Usually the Oak classes are twice in the Maven test class path. Once
transitively from
https://github.com/apache/sling-org-apache-sling-testing-sling-mock/blob/4176be162961185bc8a08d7ef56d60c2ba8c3028/core/pom.xml#L170
and once from this shading. Therefore the order matters here. Can we somehow
do an in advance check to make sure that right version is loaded?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
