kwin commented on a change in pull request #4:
URL: 
https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/pull/4#discussion_r757799018



##########
File path: pom.xml
##########
@@ -180,7 +167,7 @@
                 <artifactId>maven-shade-plugin</artifactId>
                 <configuration>
                     <!--
-                        embed all jackrabbit artifacts to prevent classpath 
clashes
+                        embed all jackrabbit artifacts, to prevent classpath 
clashes

Review comment:
       I tested with ACS AEM Commons depending on wcm.io dependencies for AEM 
6.4 (and it works fine): 
https://github.com/Adobe-Consulting-Services/acs-aem-commons/pull/2700/commits/7ed39a321c3d342612961595920beb3887d85c8d




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to