kwin commented on a change in pull request #4:
URL:
https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/pull/4#discussion_r757934520
##########
File path: pom.xml
##########
@@ -180,7 +167,7 @@
<artifactId>maven-shade-plugin</artifactId>
<configuration>
<!--
- embed all jackrabbit artifacts to prevent classpath
clashes
+ embed all jackrabbit artifacts, to prevent classpath
clashes
Review comment:
After removing the dependency in
https://github.com/wcm-io/wcm-io-testing/blob/679d511e90214b4fa8a5a9d3d47a3f342461a1f8/aem-mock/core/pom.xml#L107-L111
everything `mvn clean install` works fine on wcm-io-testing (all modules)
tested against this sling-mock-oak dependency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
